lidavidm commented on a change in pull request #9656:
URL: https://github.com/apache/arrow/pull/9656#discussion_r590484973



##########
File path: cpp/src/arrow/ipc/reader.h
##########
@@ -169,6 +170,17 @@ class ARROW_EXPORT RecordBatchFileReader {
 
   /// \brief Return current read statistics
   virtual ReadStats stats() const = 0;
+
+  /// \brief Get a reentrant generator of record batches.
+  ///
+  /// This RecordBatchFileReader must outlive the generator.

Review comment:
       Thanks - this was actually left over from an earlier approach. I've 
removed the note and adjusted the test to ensure the reader gets dropped before 
the generator.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to