rok commented on code in PR #43537:
URL: https://github.com/apache/arrow/pull/43537#discussion_r1750286811
##########
python/pyarrow/_flight.pyx:
##########
@@ -736,16 +742,47 @@ cdef class FlightEndpoint(_Weakrefable):
CLocation.Parse(tobytes(location)).Value(&c_location))
self.endpoint.locations.push_back(c_location)
+ if expiration_time is not None:
+ self.endpoint.expiration_time = TimePoint_from_ns(
+ expiration_time.cast(timestamp("ns")).value)
Review Comment:
Looking at how we do `optional` elsewhere, how about:
```suggestion
if expiration_time is not None:
self.endpoint.expiration_time = <optional[CTimePoint]>(
TimePoint_from_ns(expiration_time.value.cast(timestamp("ns"))))
```
Or maybe even:
```suggestion
self.endpoint.expiration_time = <optional[CTimePoint]>nullopt if
expiration_time is None else
<optional[CTimePoint]>(TimePoint_from_ns(expiration_time.value.cast(timestamp("ns"))))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
