EnricoMi commented on code in PR #43537:
URL: https://github.com/apache/arrow/pull/43537#discussion_r1764796379
##########
python/pyarrow/_flight.pyx:
##########
@@ -736,16 +742,48 @@ cdef class FlightEndpoint(_Weakrefable):
CLocation.Parse(tobytes(location)).Value(&c_location))
self.endpoint.locations.push_back(c_location)
+ if expiration_time is not None:
+ self.endpoint.expiration_time =
TimePoint_to_system_time(TimePoint_from_ns(
+ expiration_time.cast(timestamp("ns")).value))
+
+ self.endpoint.app_metadata = tobytes(app_metadata)
Review Comment:
Optional in the sense that there is a default value for `app_metadata`.
Documentation does not say `app_metadata` can be `None`, as in `Optional[str]`.
I can make it None-safe, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
