pitrou commented on code in PR #44047:
URL: https://github.com/apache/arrow/pull/44047#discussion_r1756829255
##########
python/pyarrow/src/arrow/python/helpers.cc:
##########
@@ -292,7 +292,11 @@ bool PyFloat_IsNaN(PyObject* obj) {
namespace {
+#ifdef Py_GIL_DISABLED
Review Comment:
No need for conditional compilation IMHO, let's just use `std::once_flag`
always.
##########
python/pyarrow/src/arrow/python/helpers.cc:
##########
@@ -306,13 +310,7 @@ static PyObject* pandas_DateOffset = nullptr;
} // namespace
-void InitPandasStaticData() {
- // NOTE: This is called with the GIL held. We needn't (and shouldn't,
- // to avoid deadlocks) use an additional C++ lock (ARROW-10519).
- if (pandas_static_initialized) {
- return;
- }
-
+void GetPandasStaticSymbols() {
Review Comment:
Can you move this to the anonymous namespace above? This is a private
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
