lysnikolaou commented on code in PR #44047:
URL: https://github.com/apache/arrow/pull/44047#discussion_r1756839385
##########
python/pyarrow/src/arrow/python/helpers.cc:
##########
@@ -292,7 +292,11 @@ bool PyFloat_IsNaN(PyObject* obj) {
namespace {
+#ifdef Py_GIL_DISABLED
Review Comment:
I used a conditional cause this could theoretically introduce a deadlock
when the GIL is there. You removed the `std::once_flag` in
https://github.com/apache/arrow/commit/f69061935e92e36e25bb891177ca8bc4f463b272.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
