paleolimbot commented on code in PR #586:
URL: https://github.com/apache/arrow-nanoarrow/pull/586#discussion_r1757083934
##########
python/src/nanoarrow/array.py:
##########
@@ -542,6 +542,29 @@ def __iter__(self):
"to iterate over elements of this Array"
)
+ def serialize(self, dst=None) -> Union[bytes, None]:
Review Comment:
I think `Optional` is OK but `|` is 3.10 or higher (we should be using
Optional everywhere but I didn't know about it when I started writing type
hints. At some point we can go back and change them all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
