paleolimbot commented on code in PR #586:
URL: https://github.com/apache/arrow-nanoarrow/pull/586#discussion_r1757120445
##########
python/src/nanoarrow/ipc.py:
##########
@@ -236,9 +243,198 @@ def __repr__(self) -> str:
return f"<{class_label} <invalid>>"
+class Writer:
Review Comment:
`Stream` is a bit of a compromise...we can't just "subclass a record batch
reader" like is done in Arrow C++/Pyarrow, but we need a place to put the code
that deals with file IO...so the stream is sort of an internal stepping stone
to eliminate anything dealing with files in
`nanoarrow.array_stream.ArrayStream`. It should have a better name now that its
purpose is more clear.
`Writer` is definitely a user-facing concept and should probably be a
`StreamWriter` (since it doesn't do files)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
