kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1758364222
##########
ci/scripts/integration_arrow.sh:
##########
@@ -63,10 +63,15 @@ time archery integration \
--run-ipc \
--run-flight \
--with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0")
\
+ --target-language=cpp \
--with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" ||
echo "0") \
+ --target-language=csharp \
--with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \
+ --target-language=go \
--with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo
"0") \
+ --target-language=java \
--with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \
+ --target-language=js \
Review Comment:
This file is used by apache/arrow-rs too.
So embedding `--target-language` here isn't a good approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
