pitrou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1763141360
##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
def run_all_tests(with_cpp=True, with_java=True, with_js=True,
with_csharp=True, with_go=True, with_rust=False,
with_nanoarrow=False, run_ipc=False, run_flight=False,
- run_c_data=False, tempdir=None, **kwargs):
+ run_c_data=False, tempdir=None, target_languages="",
+ **kwargs):
tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+ print(["before", target_languages])
+ target_languages = list(filter(len, target_languages.split(",")))
Review Comment:
Why the `filter` call?
##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
def run_all_tests(with_cpp=True, with_java=True, with_js=True,
with_csharp=True, with_go=True, with_rust=False,
with_nanoarrow=False, run_ipc=False, run_flight=False,
- run_c_data=False, tempdir=None, **kwargs):
+ run_c_data=False, tempdir=None, target_languages="",
+ **kwargs):
tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+ print(["before", target_languages])
Review Comment:
You should remove those `print` calls
##########
dev/archery/archery/cli.py:
##########
@@ -744,6 +744,9 @@ def _set_default(opt, default):
@click.option('--with-rust', type=bool, default=False,
help='Include Rust in integration tests',
envvar="ARCHERY_INTEGRATION_WITH_RUST")
[email protected]('--target-languages', default='',
+ help=('Target languages in this integration tests'),
+ envvar="ARCHERY_INTEGRATION_TARGET_LANGUAGES")
Review Comment:
Uh, can the help string be more explanatory? It's really not possible to
understand what this does from the current wording.
##########
dev/archery/archery/cli.py:
##########
@@ -744,6 +744,9 @@ def _set_default(opt, default):
@click.option('--with-rust', type=bool, default=False,
help='Include Rust in integration tests',
envvar="ARCHERY_INTEGRATION_WITH_RUST")
[email protected]('--target-languages', default='',
Review Comment:
"Languages" is not really right here, as nanoarrow for example is not a
language. "Implementations" perhaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
