zeroshade commented on code in PR #43957:
URL: https://github.com/apache/arrow/pull/43957#discussion_r1761336406
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -336,8 +336,8 @@ struct ProductImpl : public ScalarAggregator {
internal::VisitArrayValuesInline<ArrowType>(
data,
[&](typename TypeTraits<ArrowType>::CType value) {
- this->product =
- MultiplyTraits<AccType>::Multiply(*out_type, this->product,
value);
+ this->product = MultiplyTraits<AccType>::Multiply(
+ *out_type, this->product, static_cast<ProductType>(value));
Review Comment:
Because the constructors for Decimal32/Decimal64 are marked `explicit` I
needed to explicitly add casts there to satisfy the templates for conversions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
