felipecrv commented on code in PR #43957:
URL: https://github.com/apache/arrow/pull/43957#discussion_r1757833095
##########
cpp/src/arrow/array/array_test.cc:
##########
@@ -667,8 +667,10 @@ static ScalarVector GetScalars() {
std::make_shared<BinaryViewScalar>(hello),
std::make_shared<FixedSizeBinaryScalar>(
hello, fixed_size_binary(static_cast<int32_t>(hello->size()))),
- std::make_shared<Decimal128Scalar>(Decimal128(10), decimal(16, 4)),
- std::make_shared<Decimal256Scalar>(Decimal256(10), decimal(76, 38)),
+ std::make_shared<Decimal32Scalar>(Decimal32(10), smallest_decimal(7, 4)),
+ std::make_shared<Decimal64Scalar>(Decimal64(10), smallest_decimal(12,
4)),
+ std::make_shared<Decimal128Scalar>(Decimal128(10), smallest_decimal(20,
4)),
+ std::make_shared<Decimal256Scalar>(Decimal256(10), smallest_decimal(76,
38)),
Review Comment:
Alright. Can we name it something shorter? I have at least 3 suggestions:
- `best_decimal`
- `fast_decimal`
- `least_decimal`
Some of these naming conventions exist in the C++ standard library
https://en.cppreference.com/w/cpp/types/integer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
