bkietz commented on code in PR #41559: URL: https://github.com/apache/arrow/pull/41559#discussion_r1764276071
########## cpp/src/arrow/adapters/orc/util.cc: ########## @@ -18,6 +18,7 @@ #include "arrow/adapters/orc/util.h" #include <cmath> +#include <sstream> Review Comment: This is used in `GetOrcMajorVersion()`, so it should be #included here by IWYU. I found it because compilation failed at one point (compilation can spuriously succeed when standard headers include more definitions than the standard guarantees; for example, inclusion of only `<string>` or `<iostream>` might fully define `std::stringstream` rather than only forward declaring it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
