assignUser commented on code in PR #41559:
URL: https://github.com/apache/arrow/pull/41559#discussion_r1777807654


##########
cpp/src/arrow/filesystem/CMakeLists.txt:
##########
@@ -121,6 +121,24 @@ if(ARROW_S3)
       target_link_libraries(arrow-filesystem-s3fs-benchmark PRIVATE 
parquet_shared)
     endif()
   endif()
+
+  if(ARROW_S3_MODULE)
+    add_arrow_test(s3fs_module_test
+                   SOURCES
+                   s3fs_module_test.cc
+                   s3_test_util.cc
+                   EXTRA_LABELS
+                   filesystem
+                   DEFINITIONS
+                   ARROW_S3_LIBPATH="$<TARGET_FILE:arrow_s3fs>"
+                   EXTRA_LINK_LIBS
+                   Boost::filesystem
+                   Boost::system)

Review Comment:
   Sorry, missed that ping. But yes, that is possible  Ben says, I have done 
something similar for velox custom functions. But currently I am a little 
concerned that cmake-format seems to be unmaintained 
https://github.com/cheshirekow/cmake_format/issues/340



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to