kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764593328
##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
def run_all_tests(with_cpp=True, with_java=True, with_js=True,
with_csharp=True, with_go=True, with_rust=False,
with_nanoarrow=False, run_ipc=False, run_flight=False,
- run_c_data=False, tempdir=None, **kwargs):
+ run_c_data=False, tempdir=None, target_languages="",
+ **kwargs):
tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+ print(["before", target_languages])
+ target_languages = list(filter(len, target_languages.split(",")))
Review Comment:
Because `--target-languages=cpp,java` is an input. We need to extract `cpp`
and `java` from `cpp,java`.
I know that click supports `--target-language=cpp --target-languages=java`
style. But reusing `ci/scripts/integration_arrow.sh` in apache/arrow,
apache/arrow-rs, apache/arrow-nanoarrow and apache/arrow-go is difficult with
the style. Entirely overwritable `--target-languages=cpp,java` style is easy to
reusable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
