paleolimbot commented on code in PR #614:
URL: https://github.com/apache/arrow-nanoarrow/pull/614#discussion_r1765414811
##########
CMakeLists.txt:
##########
@@ -337,9 +338,10 @@ if(NANOARROW_TESTING
PUBLIC
$<BUILD_INTERFACE:${NANOARROW_BUILD_INCLUDE_DIR}>
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/src>
$<INSTALL_INTERFACE:include>)
- target_link_libraries(nanoarrow_testing PRIVATE nlohmann_json::nlohmann_json
nanoarrow)
- target_link_libraries(nanoarrow_testing PUBLIC nanoarrow)
+ target_link_libraries(nanoarrow_testing PRIVATE nlohmann_json::nlohmann_json)
+ target_link_libraries(nanoarrow_testing PUBLIC nanoarrow
nanoarrow_coverage_config)
Review Comment:
Way cleaner...thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
