paleolimbot commented on code in PR #614: URL: https://github.com/apache/arrow-nanoarrow/pull/614#discussion_r1765415702
########## examples/cmake-scenarios/build.sh: ########## @@ -20,12 +20,18 @@ set -exuo pipefail # Build nanoarrow statically. -cmake -S ../.. -B scratch/nanoarrow_build_static/ -DCMAKE_INSTALL_PREFIX=scratch/nanoarrow_install_static/ +cmake -S ../.. -B scratch/nanoarrow_build_static/ \ + -DCMAKE_INSTALL_PREFIX=scratch/nanoarrow_install_static/ \ + -DNANOARROW_IPC=ON -DNANOARROW_DEVICE=ON -DNANOARROW_TESTING=ON Review Comment: We don't currently use presets for anything (although we do define a few and possibly should make better use of them!). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
