andygrove commented on code in PR #6419:
URL: https://github.com/apache/arrow-rs/pull/6419#discussion_r1765691467
##########
arrow-data/src/decimal.rs:
##########
@@ -738,23 +738,32 @@ pub fn validate_decimal_precision(value: i128, precision:
u8) -> Result<(), Arro
"Max precision of a Decimal128 is {DECIMAL128_MAX_PRECISION}, but
got {precision}",
)));
}
-
- let max = MAX_DECIMAL_FOR_EACH_PRECISION[usize::from(precision) - 1];
- let min = MIN_DECIMAL_FOR_EACH_PRECISION[usize::from(precision) - 1];
Review Comment:
I believe that this is where the `memcpy` was being introduced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
