andygrove commented on PR #6419: URL: https://github.com/apache/arrow-rs/pull/6419#issuecomment-2361775816
> thanks @andygrove probably a nit: I can see `usize::from(precision) - 1` a lot which require new allocation of usize. My feeling the precision is static? may we can precompute idx and pass it by reference? What if we just insert an extra element in the start of each of the lookup arrays and then just use `precision as usize` directly as the index? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
