etseidl commented on code in PR #6392:
URL: https://github.com/apache/arrow-rs/pull/6392#discussion_r1767330170


##########
parquet/src/errors.rs:
##########
@@ -61,6 +66,8 @@ impl std::fmt::Display for ParquetError {
                 write!(fmt, "Index {index} out of bound: {bound}")
             }
             ParquetError::External(e) => write!(fmt, "External: {e}"),
+            ParquetError::NeedMoreData(needed) => write!(fmt, "NeedMoreData: 
{needed}"),

Review Comment:
   I wasn't intending two, it just turned out that way. I could make the second 
`usize` optional with the understanding that a range is being requested.
   
   Also, does adding to the enum make this a breaking change?  If so, I could 
go back to my tortured use of `IndexOutOfBound` until it's open season on 
breaking changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to