alamb commented on code in PR #6392:
URL: https://github.com/apache/arrow-rs/pull/6392#discussion_r1767367716
##########
parquet/src/errors.rs:
##########
@@ -61,6 +66,8 @@ impl std::fmt::Display for ParquetError {
write!(fmt, "Index {index} out of bound: {bound}")
}
ParquetError::External(e) => write!(fmt, "External: {e}"),
+ ParquetError::NeedMoreData(needed) => write!(fmt, "NeedMoreData:
{needed}"),
Review Comment:
>
Also, does adding to the enum make this a breaking change? If so, I could go
back to my tortured use of IndexOutOfBound until it's open season on breaking
changes.
Yes, unfortunately, it does make it a breaking change
https://github.com/apache/arrow-rs/blob/master/parquet/src/errors.rs#L29
We should probably mark the error type [as "non exhaustive"
](https://doc.rust-lang.org/reference/attributes/type_system.html#:~:text=The%20non_exhaustive%20attribute%20indicates%20that,crate%2C%20non_exhaustive%20has%20no%20effect.)
which would make it a non breaking change in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
