alamb commented on code in PR #6441:
URL: https://github.com/apache/arrow-rs/pull/6441#discussion_r1771531739
##########
arrow-row/src/lib.rs:
##########
@@ -1491,10 +1491,7 @@ mod tests {
let converter = RowConverter::new(vec![SortField::new_with_options(
DataType::Boolean,
- SortOptions {
- descending: true,
- nulls_first: false,
- },
+ SortOptions::default().desc().with_nulls_first(false),
Review Comment:
Here is an example of using the new API
Not only is this more concise, I believe the intent is easier to reason
about now (asc/desc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
