etseidl commented on code in PR #6441:
URL: https://github.com/apache/arrow-rs/pull/6441#discussion_r1771861845
##########
arrow-schema/src/lib.rs:
##########
@@ -42,6 +73,56 @@ pub struct SortOptions {
pub nulls_first: bool,
}
+impl Display for SortOptions {
+ fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
+ if self.descending {
+ write!(f, "DESC")?;
+ } else {
+ write!(f, "ASC")?;
+ }
+ if self.nulls_first {
+ // purposely don't display default NULLs value
Review Comment:
The default for `nulls_first` doesn't seem to be documented, so wouldn't it
be clearer to print the value here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
