rok commented on code in PR #44215:
URL: https://github.com/apache/arrow/pull/44215#discussion_r1774937588
##########
cpp/src/parquet/arrow/arrow_schema_test.cc:
##########
@@ -763,7 +763,7 @@ TEST_F(TestConvertParquetSchema,
ParquetSchemaArrowExtensions) {
props.set_arrow_extensions_enabled(true);
auto arrow_schema = ::arrow::schema(
{::arrow::field("json_1", ::arrow::extension::json(), true),
- ::arrow::field("json_2",
::arrow::extension::json(::arrow::large_utf8()),
+ ::arrow::field("json_2", ::arrow::extension::json(::arrow::utf8()),
Review Comment:
Added another assertion to justify changing `arrow_schema`
https://github.com/apache/arrow/pull/44215/files/94006f92085377fc4b72c2a2da844e36fb4d86d3..77c964b04972fc08f04957190866fb475b453c3c.
Let me know if something else should be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
