rok commented on code in PR #44215:
URL: https://github.com/apache/arrow/pull/44215#discussion_r1775449866
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -1017,7 +1017,9 @@ Result<bool> ApplyOriginalMetadata(const Field&
origin_field, SchemaField* infer
// Restore extension type, if the storage type is the same as inferred
// from the Parquet type
- if (ex_type.storage_type()->Equals(*inferred->field->type())) {
+ if (ex_type.storage_type()->Equals(*inferred->field->type()) ||
+ (ex_type.extension_name() == "arrow.json" &&
+ !ex_type.storage_type()->Equals(*inferred->field->type()))) {
Review Comment:
It is superfluous indeed. Changed as per your suggestion:
https://github.com/apache/arrow/pull/44215/commits/3364c0f0f70a37c84e134043537c4ee4d55fbbd6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
