crepererum commented on code in PR #6540:
URL: https://github.com/apache/arrow-rs/pull/6540#discussion_r1796774093
##########
arrow-array/src/array/list_array.rs:
##########
@@ -1181,4 +1181,18 @@ mod tests {
.collect();
assert_eq!(values, vec![Some(vec![1, 2, 3]), None, Some(vec![4, 5,
6])])
}
+
+ #[test]
Review Comment:
Could we also have a more direct check for the code change, i.e. one that
directly asserts `UnionArray::is_nullable` (in the respective module)? I'm fine
with keeping the actual regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
