alamb commented on code in PR #6540:
URL: https://github.com/apache/arrow-rs/pull/6540#discussion_r1804557268
##########
arrow-array/src/array/list_array.rs:
##########
@@ -1181,4 +1181,18 @@ mod tests {
.collect();
assert_eq!(values, vec![Some(vec![1, 2, 3]), None, Some(vec![4, 5,
6])])
}
+
+ #[test]
Review Comment:
I also added a specific test in e78c87bff9
##########
arrow-array/src/array/list_array.rs:
##########
@@ -1181,4 +1181,18 @@ mod tests {
.collect();
assert_eq!(values, vec![Some(vec![1, 2, 3]), None, Some(vec![4, 5,
6])])
}
+
+ #[test]
Review Comment:
I verified that this test fails without the code change:
```
called `Result::unwrap()` on an `Err` value:
InvalidArgumentError("Non-nullable field of ListArray \"element\" cannot
contain nulls")
thread 'array::list_array::tests::test_nullable_union' panicked at
arrow-array/src/array/list_array.rs:228:54:
called `Result::unwrap()` on an `Err` value:
InvalidArgumentError("Non-nullable field of ListArray \"element\" cannot
contain nulls")
stack backtrace:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
