bkirwi commented on code in PR #6524:
URL: https://github.com/apache/arrow-rs/pull/6524#discussion_r1797325475


##########
parquet/Cargo.toml:
##########
@@ -71,6 +71,9 @@ sysinfo = { version = "0.31.2", optional = true, 
default-features = false, featu
 crc32fast = { version = "1.4.2", optional = true, default-features = false }
 
 [dev-dependencies]
+# Enable additional validations when running tests

Review Comment:
   Ah yeah - I'd forgotten this would enable the feature for other crates when 
running tests in batch.
   
   I didn't find any fuzz tests in parquet that would be easy to adapt. I ended 
up adding a new roundtrip test, and enhancing some of the default roundtrip 
validations to catch the issue.
   
   I suspect it may make sense to add some negative tests and other coverage. 
I'm happy to come back to that if folks like the overall approach here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to