findepi commented on code in PR #6427:
URL: https://github.com/apache/arrow-rs/pull/6427#discussion_r1801553123
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -114,7 +114,7 @@ use super::ByteArrayType;
pub struct GenericByteViewArray<T: ByteViewType + ?Sized> {
data_type: DataType,
views: ScalarBuffer<u128>,
- buffers: Vec<Buffer>,
+ buffers: Arc<[Buffer]>,
Review Comment:
> you would have to create a new `Vec<Buffer`>
but that would prevent buffer sharing between two arrays, right?
> slicing / cloning is faster
cloning yes
slicing -- i didn't see it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
