alamb commented on code in PR #6427:
URL: https://github.com/apache/arrow-rs/pull/6427#discussion_r1801609765
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -114,7 +114,7 @@ use super::ByteArrayType;
pub struct GenericByteViewArray<T: ByteViewType + ?Sized> {
data_type: DataType,
views: ScalarBuffer<u128>,
- buffers: Vec<Buffer>,
+ buffers: Arc<[Buffer]>,
Review Comment:
I think the observation is that during `StringViewArray::slice`, the `slice`
actually happens on the `view`s -- the buffers (that the views can point at)
must be copied
Here is the clone of `buffers`:
https://docs.rs/arrow-array/53.1.0/src/arrow_array/array/byte_view_array.rs.html#385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
