trifleneurotic commented on code in PR #44503:
URL: https://github.com/apache/arrow/pull/44503#discussion_r1812481639
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -489,17 +489,13 @@ TEST(GcsFileSystem, FileSystemCompare) {
a_options.project_id = "test-only-invalid-project-id";
auto a = GcsFileSystem::Make(a_options);
EXPECT_THAT(a, NotNull());
- EXPECT_TRUE(a->Equals(*a));
Review Comment:
There is no need to remove this with your suggested change. That change has
been made, and the above line has been restored. Ref
49fd6d0e0a4fefadc7083e5e4fa392c3528669cf. (EDIT: incorrect commit hash).
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -622,7 +618,7 @@ TEST(GcsFileSystem, ObjectMetadataRoundtrip) {
}
TEST_F(GcsIntegrationTest, GetFileInfoBucket) {
- auto fs = GcsFileSystem::Make(TestGcsOptions());
+ ASSERT_OK_AND_ASSIGN(std::shared_ptr<GcsFileSystem> fs,
GcsFileSystem::Make(TestGcsOptions()));
Review Comment:
Complete! Ref 49fd6d0e0a4fefadc7083e5e4fa392c3528669cf. (EDIT: incorrect
commit hash).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
