kou commented on code in PR #44503:
URL: https://github.com/apache/arrow/pull/44503#discussion_r1813722300
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -271,7 +271,8 @@ class TestGCSFSGeneric : public GcsIntegrationTest, public
GenericFileSystemTest
void SetUp() override {
ASSERT_NO_FATAL_FAILURE(GcsIntegrationTest::SetUp());
auto bucket_name = RandomBucketName();
- gcs_fs_ = GcsFileSystem::Make(TestGcsOptions());
+ ASSERT_OK_AND_ASSIGN(std::shared_ptr<GcsFileSystem> gcs_fs_,
Review Comment:
```suggestion
ASSERT_OK_AND_ASSIGN(gcs_fs_,
```
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -497,9 +498,6 @@ TEST(GcsFileSystem, FileSystemCompare) {
b_options.project_id = "test-only-invalid-project-id";
auto b = GcsFileSystem::Make(b_options);
EXPECT_THAT(b, NotNull());
- EXPECT_TRUE(b->Equals(*b));
-
- EXPECT_FALSE(a->Equals(*b));
Review Comment:
Can we revert these changes?
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -632,7 +630,7 @@ TEST_F(GcsIntegrationTest, GetFileInfoBucket) {
TEST_F(GcsIntegrationTest, GetFileInfoObjectWithNestedStructure) {
// Adds detailed tests to handle cases of different edge cases
// with directory naming conventions (e.g. with and without slashes).
- auto fs = GcsFileSystem::Make(TestGcsOptions());
+ ASSERT_OK_AND_ASSIGN(std::shared_ptr<GcsFileSystem> fs,
GcsFileSystem::Make(TestGcsOptions()));
Review Comment:
Can we keep `auto`?
BTW, we have many similar changes. Could you do self-review again?
##########
cpp/src/arrow/filesystem/gcsfs.h:
##########
@@ -230,9 +230,7 @@ class ARROW_EXPORT GcsFileSystem : public FileSystem {
const std::string& path,
const std::shared_ptr<const KeyValueMetadata>& metadata) override;
- /// Create a GcsFileSystem instance from the given options.
Review Comment:
We don't need to remove this comment too. Could you revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
