tustvold commented on PR #6616: URL: https://github.com/apache/arrow-rs/pull/6616#issuecomment-2432834395
> The consistency of kernel behavior and design is higher than such minor optimization Perhaps you could articulate what the policy is you expect to be? Should all kernels deep clone all inputs? Would this not have severe performance ramifications? > For now, users need to dig into the details inside the kernel when calling Yes relying on behaviour beyond the documented contract of a kernel is a recipe for needing to dig into the details of said function. https://xkcd.com/1172/ comes to mind here. > I don't think this is a good design from a higher level point of view. We may have to agree to disagree, but let's see what Andrew has to say -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
