viirya commented on PR #6616: URL: https://github.com/apache/arrow-rs/pull/6616#issuecomment-2433126849
> Perhaps you could articulate what the policy is you expect to be? Should all kernels deep clone all inputs? Would this not have severe performance ramifications? For `take` kernel, the current behavior surprises me. Although we don't explicitly say it won't clone input array. But I image that for an user without any knowledge about its internals, it "takes" some elements from input array, so it means it "copies" values from the input and produce a "new" output. This is the `take` kernel document: > Take elements by index from [Array], creating a new [Array] from those indexes. I'm not sure for others, but for me "take" semantics is to have something separately, not share it. The current behavior is counterintuitive (at least to me). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
