WillAyd commented on PR #644:
URL: https://github.com/apache/arrow-nanoarrow/pull/644#issuecomment-2433673498
I think your proposal would work if you only ever installed from an sdist,
but wouldn't work when building from this repo. Let me see if I can clarify.
Assume we had a structure like this:
```
src/
nanoarrow.c
python/
src/
nanoarrow_c.pxd
```
The PR as it currently stands will copy the `src/nanoarrow.c` file into the
build folder and reference it from there:
```
src/
nanoarrow.c
python/
src/
nanoarrow_c.pxd
builddir/ # generated at build time
nanoarrow.c
```
What you are proposing is to generate an sdist before installing the package
with a layout that may look something like:
```
src/
nanoarrow.c
python/
src/
nanoarrow_c.pxd
vendor/
nanoarrow.c
```
However, I don't know of a simple way for Meson/ninja to resolve to a source
file potentially in the source tree (when installing from an sdist) while
falling back to looking for it in the build folder (when building in this repo)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
