WillAyd commented on code in PR #644:
URL: https://github.com/apache/arrow-nanoarrow/pull/644#discussion_r1821175416
##########
meson.build:
##########
@@ -103,7 +105,7 @@ if get_option('ipc')
)
nanoarrow_ipc_dep = declare_dependency(include_directories: [incdir],
link_with: nanoarrow_ipc_lib,
- dependencies: [nanoarrow_dep,
flatcc_dep])
+ dependencies: [nanoarrow_dep])
Review Comment:
Yea this removal here essentially removes the flatcc headers from being
included by downstream targets that use the nanoarrow_ipc_dep; this is akin to
changing the flatcc target inclusion from PUBLIC to PRIVATE in CMake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
