zeroshade commented on code in PR #171:
URL: https://github.com/apache/arrow-go/pull/171#discussion_r1815856802
##########
arrow/compute/exprs/exec_test.go:
##########
@@ -135,8 +137,12 @@ func TestComparisons(t *testing.T) {
one = scalar.MakeScalar(int32(1))
two = scalar.MakeScalar(int32(2))
- str = scalar.MakeScalar("hello")
- bin = scalar.MakeScalar([]byte("hello"))
+ str = scalar.MakeScalar("hello")
+ bin = scalar.MakeScalar([]byte("hello"))
+ exampleUUID =
uuid.MustParse("102cb62f-e6f8-4eb0-9973-d9b012ff0967")
+ uidStorage, _ = scalar.MakeScalarParam(exampleUUID[:],
+ &arrow.FixedSizeBinaryType{ByteWidth: 16})
+ uid = scalar.NewExtensionScalar(uidStorage,
extensions.NewUUIDType())
Review Comment:
`uuid` is used as the name of the `uuid` package, so I'd end up with a
conflict / issue if I use the name for the variable here. I can rename it as
something else though if we prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
