zeroshade commented on code in PR #171:
URL: https://github.com/apache/arrow-go/pull/171#discussion_r1816794350
##########
parquet/pqarrow/schema.go:
##########
@@ -514,8 +515,10 @@ func arrowFromFLBA(logical schema.LogicalType, length int)
(arrow.DataType, erro
switch logtype := logical.(type) {
case schema.DecimalLogicalType:
return arrowDecimal(logtype), nil
- case schema.NoLogicalType, schema.IntervalLogicalType,
schema.UUIDLogicalType:
+ case schema.NoLogicalType, schema.IntervalLogicalType:
return &arrow.FixedSizeBinaryType{ByteWidth: int(length)}, nil
+ case schema.UUIDLogicalType:
+ return extensions.NewUUIDType(), nil
Review Comment:
I Split this out to a separate PR as per @kou's suggestion, and I've made
this change in it. It's a good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
