CurtHagenlocher commented on code in PR #2289:
URL: https://github.com/apache/arrow-adbc/pull/2289#discussion_r1821264701
##########
csharp/src/Drivers/BigQuery/BigQueryParameters.cs:
##########
@@ -35,6 +35,7 @@ public class BigQueryParameters
public const string Scopes = "adbc.bigquery.scopes";
public const string IncludeConstraintsWithGetObjects =
"adbc.bigquery.include_constraints_getobjects";
public const string GetQueryResultsOptionsTimeoutMinutes =
"adbc.bigquery.get_query_results_options.timeout";
+ public const string CreateReadSessionMaxStreamCount =
"adbc.bigquery.create_read_session.max_stream_count";
Review Comment:
Can we name this something a little more meaningful to the user like
`adbc.bigquery.max_fetch_concurrency`?
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -103,8 +103,19 @@ public override QueryResult ExecuteQuery()
string table =
$"projects/{results.TableReference.ProjectId}/datasets/{results.TableReference.DatasetId}/tables/{results.TableReference.TableId}";
+ int maxStreamCount = 1;
Review Comment:
Is `1` really the best default value here? (I don't know how we ended up
with 1; the documentation clearly recommends 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
