qifanzhang-ms commented on code in PR #2289:
URL: https://github.com/apache/arrow-adbc/pull/2289#discussion_r1822267561
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -103,8 +103,19 @@ public override QueryResult ExecuteQuery()
string table =
$"projects/{results.TableReference.ProjectId}/datasets/{results.TableReference.DatasetId}/tables/{results.TableReference.TableId}";
+ int maxStreamCount = 1;
Review Comment:
The default value is set to 1, mainly due to two reasons:
1 The original driver setting is 1. The GBQ MSDI driver is now being used by
a large number of users, and changing this setting may cause potential
regression.
2 The doc does say: If unset or zero, the server will provide a value of
streams so as to produce reasonable throughput. But I found in my test that
this is not 100% accurate. At least in the test of reading the same table, it
took 42.5 minutes when max_stream_count=1 and 46.4 minutes when
max_stream_count=0. Although this may be due to other reasons such as the test
table content or network fluctuations, it at least shows that potential
regression on perf exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
