kou commented on code in PR #44536: URL: https://github.com/apache/arrow/pull/44536#discussion_r1822127345
########## .github/workflows/d.yml: ########## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: D + +on: + push: + branches: + - '**' + - '!dependabot/**' + tags: + - '**' + paths: + - '.dockerignore' + - '.github/workflows/d.yml' + - 'ci/docker/*d*' Review Comment: All `.dockerfile`s are matched... ########## ci/docker/ubuntu-d.dockerfile: ########## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +ARG base=amd64/ubuntu:24.04 +FROM ${base} + +SHELL ["/bin/bash", "-o", "pipefail", "-c"] + +RUN echo "debconf debconf/frontend select Noninteractive" | + debconf-set-selections + +# Install ldc2 toolchain (dmd-frontend + llvm-backend) & dub package manager +RUN apt-get update -y -q && + apt-get install -y -q --no-install-recommends \ + ldc \ + dub \ + unzip \ Review Comment: Could you sort this list in alphabetical order? ########## d/source/APILookup.txt: ########## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +includeComments: y + +lookup: APILookupArrow.txt +################ +##### TODO ##### +################ +# lookup: APILookupArrowDataset.txt +# lookup: APILookupArrowFlight.txt Review Comment: Could you remove them for now? Let's work on them as follow-up tasks. ########## d/README.md: ########## @@ -0,0 +1,43 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Apache Arrow + +An implementation of Arrow targeting D programming language. + +See our current [feature matrix](https://github.com/apache/arrow/blob/main/docs/source/status.rst) +for currently available features. + +# Requirements + +- [dmd/gdc/ldc2](https://dlang.org/download) with druntime-frontend 2.105.0 or later + +# Building Review Comment: ```suggestion ## Building ``` ########## d/.gitignore: ########## @@ -0,0 +1,4 @@ +# unittest files +*test* Review Comment: Why do we need to ignore unittest files? Are they auto-generated in D? ########## d/README.md: ########## @@ -0,0 +1,43 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Apache Arrow + +An implementation of Arrow targeting D programming language. + +See our current [feature matrix](https://github.com/apache/arrow/blob/main/docs/source/status.rst) +for currently available features. + +# Requirements Review Comment: ```suggestion ## Requirements ``` ########## .gitignore: ########## @@ -44,6 +44,7 @@ build.ninja perf.data perf.data.old +build/ Review Comment: Why do we need this? Can we revert this? ########## d/.gitignore: ########## Review Comment: Could you add our license header? ########## d/README.md: ########## @@ -0,0 +1,43 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Apache Arrow + +An implementation of Arrow targeting D programming language. + +See our current [feature matrix](https://github.com/apache/arrow/blob/main/docs/source/status.rst) +for currently available features. + +# Requirements + +- [dmd/gdc/ldc2](https://dlang.org/download) with druntime-frontend 2.105.0 or later + +# Building + +- build Arrow library (C++) +- build C glib bindings Review Comment: ```suggestion - build Apache Arrow C++ - build Apache Arrow GLib ``` ########## d/README.md: ########## @@ -0,0 +1,43 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Apache Arrow Review Comment: ```suggestion # Apache Arrow D ``` ########## d/README.md: ########## @@ -0,0 +1,43 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Apache Arrow + +An implementation of Arrow targeting D programming language. + +See our current [feature matrix](https://github.com/apache/arrow/blob/main/docs/source/status.rst) +for currently available features. + +# Requirements + +- [dmd/gdc/ldc2](https://dlang.org/download) with druntime-frontend 2.105.0 or later + +# Building + +- build Arrow library (C++) +- build C glib bindings +- build D bindings + +```bash Review Comment: ```suggestion ```console ``` ########## d/source/APILookupArrowFlight.txt: ########## Review Comment: Could you remove this in this PR? ########## d/source/APILookupArrowDataset.txt: ########## Review Comment: Could you remove this in this PR? ########## docker-compose.yml: ########## @@ -955,6 +956,20 @@ services: /arrow/ci/scripts/python_build.sh /arrow /build && /arrow/ci/scripts/python_test.sh /arrow" + ubuntu-d: + # Usage: + # docker-compose build ubuntu-d + # docker-compose run --rm ubuntu-d + # Parameters: + image: ubuntu-d + build: + context: . + dockerfile: ci/docker/ubuntu-d.dockerfile + shm_size: *shm-size + volumes: *ubuntu-volumes + command: > + /bin/bash -c "/arrow/ci/scripts/d_test.sh /arrow" Review Comment: Could you build Apache Arrow C++ and GLib before `d_test.sh`? We can use `ci/scripts/{cpp,c_glib}_build.sh` like other services. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
