EnricoMi commented on code in PR #44470:
URL: https://github.com/apache/arrow/pull/44470#discussion_r1824182546
##########
cpp/src/arrow/acero/options.h:
##########
@@ -103,8 +103,8 @@ class ARROW_ACERO_EXPORT SourceNodeOptions : public
ExecNodeOptions {
std::shared_ptr<Schema> output_schema;
/// \brief an asynchronous stream of batches ending with std::nullopt
std::function<Future<std::optional<ExecBatch>>()> generator;
-
- Ordering ordering = Ordering::Unordered();
Review Comment:
The constructor has a default value for ordering and initializes `ordering`
with the value given to the constructor. No point for another default value
here, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
