gitmodimo commented on PR #44470: URL: https://github.com/apache/arrow/pull/44470#issuecomment-2450276772
Since you are fixing dataset write ordering I think [this check](https://github.com/gitmodimo/arrow/blob/53859262ea988f31ce33a469305251064b5a53b8/cpp/src/arrow/acero/accumulation_queue.cc#L90) never fires. It should be moved to InsertBatch. Also probaly `AccumulationQueue`, `SequencingQueue` and `SerialSequencingQueue` should be exported for acero nodes developers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
