mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r594465495
##########
File path: cpp/src/arrow/adapters/orc/adapter_util.cc
##########
@@ -40,15 +44,21 @@ namespace orc {
using internal::checked_cast;
-// The number of nanoseconds in a second
+// The number of milliseconds, microseconds and nanoseconds in a second
+constexpr int64_t kOneSecondMillis = 1000LL;
+constexpr int64_t kOneMicroNanos = 1000LL;
+constexpr int64_t kOneSecondMicros = 1000000LL;
+constexpr int64_t kOneMilliNanos = 1000000LL;
constexpr int64_t kOneSecondNanos = 1000000000LL;
+// Jan 1st 2015 in UNIX timestamp
+// constexpr int64_t kConverter = 1420070400LL;
Status AppendStructBatch(const liborc::Type* type, liborc::ColumnVectorBatch*
cbatch,
int64_t offset, int64_t length, ArrayBuilder*
abuilder) {
auto builder = checked_cast<StructBuilder*>(abuilder);
auto batch = checked_cast<liborc::StructVectorBatch*>(cbatch);
- const uint8_t* valid_bytes = nullptr;
+ const uint8_t* valid_bytes = NULLPTR;
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
