mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r594782962
##########
File path: cpp/src/arrow/adapters/orc/adapter_util.h
##########
@@ -34,8 +34,17 @@ namespace orc {
Status GetArrowType(const liborc::Type* type, std::shared_ptr<DataType>* out);
+Status GetORCType(const DataType& type, ORC_UNIQUE_PTR<liborc::Type>* out);
+
+Status GetORCType(const Schema& schema, ORC_UNIQUE_PTR<liborc::Type>* out);
+
Status AppendBatch(const liborc::Type* type, liborc::ColumnVectorBatch* batch,
- int64_t offset, int64_t length, ArrayBuilder* builder);
+ int64_t offset, int64_t length, arrow::ArrayBuilder*
builder);
+
+Status WriteBatch(liborc::ColumnVectorBatch* column_vector_batch,
Review comment:
None of the symbols here is actually exposed to library users. Do we
need to document these functions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
