seddonm1 commented on pull request #9682: URL: https://github.com/apache/arrow/pull/9682#issuecomment-799831930
@alamb @andygrove I have made the changes to the core from your review but I have not built the `try_cast` vs `safe_cast` functionality yet. Here are the two names and their provenance: - SQL Server [try_cast](https://docs.microsoft.com/en-us/sql/t-sql/functions/try-cast-transact-sql?view=sql-server-ver15) - BigQuery [safe_cast](https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#safe_casting) My (changed) vote is `try_cast` for two reasons: - I like referring to another more mainstream SQL dialect (MS SQL has been around a lot longer than BigQuery) - `try_cast` does feel like a more 'rusty' implementation Based on the outcome of this vote I will raise a PR against the [sqlparser-rs](https://github.com/ballista-compute/sqlparser-rs) so we can support the same `TRY_CAST(x AS y)` syntax and then can finish this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
