seddonm1 commented on a change in pull request #9682:
URL: https://github.com/apache/arrow/pull/9682#discussion_r606037160
##########
File path: rust/datafusion/tests/sql.rs
##########
@@ -1530,16 +1530,11 @@ async fn execute(ctx: &mut ExecutionContext, sql: &str)
-> Vec<Vec<String>> {
let msg = format!("Creating physical plan for '{}': {:?}", sql, plan);
let plan = ctx.create_physical_plan(&plan).expect(&msg);
- let physical_schema = plan.schema();
let msg = format!("Executing physical plan for '{}': {:?}", sql, plan);
let results = collect(plan).await.expect(&msg);
assert_eq!(logical_schema.as_ref(), optimized_logical_schema.as_ref());
- assert_eq!(
Review comment:
This is interesting as it assumes none of the attributes can change
'dynamically' at runtime. I.e. if we `TRY_CAST` a column it can always return a
`NULL`. This does not support runtime evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
