alamb commented on a change in pull request #9722:
URL: https://github.com/apache/arrow/pull/9722#discussion_r595073362



##########
File path: rust/arrow/src/compute/kernels/sort.rs
##########
@@ -881,6 +913,33 @@ mod tests {
         assert_eq!(output, expected)
     }
 
+    // TODO remove this function

Review comment:
       I will rewrite the tests properly (with a single `SortOptions` 
parameter) if people like this API change, but I didn't bother until I know it 
is worthwhile




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to