alamb commented on pull request #9722: URL: https://github.com/apache/arrow/pull/9722#issuecomment-800197243
> I think that SortOptions is used on a per-column basis; it corresponds to how each column should be ordered (nulls first, descending). limit reflects how many entries should be outputted by sort, which IMO is column-independent. @jorgecarleitao that is a good point. Since the Arrow `sort` kernel only operates on a single column, I think the distinction is not relevant. However, since lexsort and DataFusion sort use the same `SortOptions` struct for each coulmn, that is a good reason not to add a `limit` option to them (as then it could be inconsistent across columns, potentially) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
