alamb commented on code in PR #6742:
URL: https://github.com/apache/arrow-rs/pull/6742#discussion_r1845405933
##########
.github/workflows/rust.yml:
##########
@@ -122,24 +122,21 @@ jobs:
uses: ./.github/actions/setup-builder
- name: Install cargo-msrv
run: cargo install cargo-msrv
- - name: Downgrade arrow dependencies
- run: cargo update -p ahash --precise 0.8.7
- - name: Check arrow
- working-directory: arrow
- run: cargo msrv --log-target stdout verify
- - name: Check parquet
- working-directory: parquet
- run: cargo msrv --log-target stdout verify
- - name: Check arrow-flight
- working-directory: arrow-flight
- run: cargo msrv --log-target stdout verify
- name: Downgrade object_store dependencies
working-directory: object_store
# Necessary because tokio 1.30.0 updates MSRV to 1.63
# and url 2.5.1, updates to 1.67
run: |
cargo update -p tokio --precise 1.29.1
cargo update -p url --precise 2.5.0
- - name: Check object_store
- working-directory: object_store
- run: cargo msrv --log-target stdout verify
+ - name: Check all packages
Review Comment:
This is awesome ❤️
##########
.github/workflows/rust.yml:
##########
@@ -122,24 +122,21 @@ jobs:
uses: ./.github/actions/setup-builder
- name: Install cargo-msrv
run: cargo install cargo-msrv
- - name: Downgrade arrow dependencies
- run: cargo update -p ahash --precise 0.8.7
- - name: Check arrow
- working-directory: arrow
- run: cargo msrv --log-target stdout verify
- - name: Check parquet
- working-directory: parquet
- run: cargo msrv --log-target stdout verify
- - name: Check arrow-flight
- working-directory: arrow-flight
- run: cargo msrv --log-target stdout verify
- name: Downgrade object_store dependencies
working-directory: object_store
# Necessary because tokio 1.30.0 updates MSRV to 1.63
# and url 2.5.1, updates to 1.67
run: |
cargo update -p tokio --precise 1.29.1
cargo update -p url --precise 2.5.0
- - name: Check object_store
- working-directory: object_store
- run: cargo msrv --log-target stdout verify
+ - name: Check all packages
+ run: |
+ find . -mindepth 2 -name Cargo.toml | while read -r dir
+ do
+ echo "Checking package '$dir'"
+ cargo msrv verify --manifest-path "$dir" || exit 1
+ done
+ # If no packages are using the workspace's rust-version, then it's out
of date
Review Comment:
Given that `cargo msrv` can't currently check a crate that uses the
workspace MSRV, maybe we should just remove the workspace MSRV in favor of
explicit versions in all the crates 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
