zeroshade commented on code in PR #683: URL: https://github.com/apache/arrow-nanoarrow/pull/683#discussion_r1848990414
########## src/nanoarrow/common/inline_types.h: ########## @@ -916,13 +922,14 @@ static inline void ArrowDecimalInit(struct ArrowDecimal* decimal, int32_t bitwid memset(decimal->words, 0, sizeof(decimal->words)); decimal->precision = precision; decimal->scale = scale; + // n_words will be 0 for bitwidth == 32 Review Comment: I can definitely add an explanation in a comment for it, but I don't know how to avoid the `n_words == 0` situation without updating words to be smaller, personally. I can do that if you want, but I agree it would be hard given how often it is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
